Notebook test ci #212
Merged
Notebook test ci #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Nov 5, 2024
| rm -rf tmp | ||
| mkdir tmp | ||
| jupytext --to notebook *.md | ||
| mv *.ipynb tmp && cd tmp |
There was a problem hiding this comment.
shouldnt this be part of the jb build pipeline?
There was a problem hiding this comment.
Do you mean the pipeline for the documentation?
There was a problem hiding this comment.
No this is specifically so that treon can do the testing for the notebooks
| @@ -448,6 +449,9 @@ def __init__(self, world: World, mode: WorldMode): | |||
| self.world = world | |||
| self.mode: WorldMode = mode | |||
|
|
|||
| if not "DISPLAY" in os.environ: | |||
There was a problem hiding this comment.
document this. Otherwise some user with some weird display setup may complain about not having a bullet world and this will be hell to figure out why
tomsch420
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a CI pipeline that automacillay runs all example notebooks and checks whether they are working or not
Also fixed a lot of issues with outdated code in the notebooks